Download Utils 0.4 - Remove Dependency on Log Utils, use DownloadUtilsImpl #16
+226
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexManos
reviewed
Oct 25, 2025
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public final class DownloadUtilsImpl { |
Jonathing
force-pushed
the
feat/jonathing/download-utils/0.4
branch
2 times, most recently
from
d851083 to
6b45c51
Compare
Jonathing
force-pushed
the
feat/jonathing/download-utils/0.4
branch
from
6b45c51 to
8eaf86f
Compare
|
Merging this now so I can get started updating other things that use this. If it breaks, just blame it on me and I'll fix it. Minor version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on Log Utils since it really doesn't need it. Also, moved the multi-version specific code to DownloadUtilsImpl so that the entire class doesn't have to be copied between two different projects.